chore: Exclude more packages #950
Conversation
🦋 Changeset detectedLatest commit: cf8ce94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
| function isExcluded(srcPath: string) { | ||
| return EXCLUDED_PACKAGES.some((excluded) => | ||
| function isExcluded(srcPath: string): string | undefined { | ||
| return EXCLUDED_PACKAGES.find((excluded) => |
There was a problem hiding this comment.
Same reason. I wanted to keep track of the packages that gets excluded. So we can logger.debug them.
There was a problem hiding this comment.
I don't think that's useful at all, or at least i don't see how. I'd rather have this documented in the docs
| @@ -250,11 +254,17 @@ File ${serverPath} does not exist | |||
|
|
|||
| // Only files that are actually copied | |||
| const tracedFiles: string[] = []; | |||
|
|
|||
| // Packages that are excluded and not copied | |||
| const excludedPackages = new Set<string>(); | |||
| // We don't want to copy excluded packages (e.g. sharp) | ||
| const excluded = isExcluded(from); | ||
| if (excluded) { | ||
| if (excluded && !excludedPackages.has(excluded)) { |
There was a problem hiding this comment.
I really don't understand the logic. What was the issue with the isExcluded from before ?
There was a problem hiding this comment.
I just wanted to add a debug for the packages that actually gets excluded.
Add more packages that can be excluded so they don't get copied into the final bundles
node_modules. Also add debug to determine which packages actually gets skipped. I've run the E2E successfully. These packages will be skipped now:typescriptnext/dist/compiled/babelnext/dist/compiled/babel-packagesnext/dist/compiled/amphtml-validatorIt will decrease the unzipped folder by 15mb and the zipped one with 4mb: